Skip to content

Generic error message in Log In page and debug messages #16575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

Tejas-Teju
Copy link
Contributor

@Tejas-Teju Tejas-Teju commented Feb 12, 2025

Overview,

  1. Login page, now displays "Invalid Credentials" as a generic error message for any authentication failures.
  2. Debug messages are provided at ProviderManager to check where and why the authentication has failed.

Closes gh-16484

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 12, 2025
@jzheaux
Copy link
Contributor

jzheaux commented Feb 13, 2025

Thanks, @Tejas-Teju! Will you please keep the existing casing for "Invalid credentials"? I apologize, I think my comment in the issue made it seem like we should change the case.

Also, will you please add Closes gh-16473 at the end of the commit that changes the login page? And then add Issue gh-16473 to the other commit, please.

@jzheaux jzheaux self-assigned this Feb 13, 2025
@jzheaux jzheaux added in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 13, 2025
@Tejas-Teju
Copy link
Contributor Author

Yes @jzheaux, I had the casing thing at the back of my head. I have updated it accordingly.

Do I have to include Closes or Issue in every commit?

@jzheaux
Copy link
Contributor

jzheaux commented Feb 14, 2025

Good question, @Tejas-Teju. It's helpful when reading commit logs to know what issue that commit is about, so yes, most commits refer either to an issue or a PR.

@jzheaux jzheaux added this to the 6.5.0-M2 milestone Feb 14, 2025
@jzheaux jzheaux merged commit 291162a into spring-projects:main Feb 14, 2025
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Feb 14, 2025

Thanks for another helpful contribution! This is now merged into main.

Note that I adjusted the wording slightly and propagated the stack trace in 6fdfeb3

@Tejas-Teju
Copy link
Contributor Author

Thanks for trusting me @jzheaux

Do we always need to propagate stack trace for any exception?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Log In Page should always be generic message
3 participants